Repository navigation
php-in-php: gate Context string helpers on thin/init-phase (#20571) - #20572
Merged
PurHur merged 1 commit intoJul 18, 2026
Merged
Conversation
Drop the last Context call site of StreamIoRuntime::shouldDeferHeavyStreamIoEmitters so NestedJIT string helpers use isThinStandaloneAotMain / isStandaloneInitPhase (peer #20553). Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
deleted the
agent/runtime-php-context-standalone-bodies-defer-gate
branch
July 18, 2026 14:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context::ensureFullStandaloneBodiesNestedJIT string helpers onisThinStandaloneAotMain()+StreamIoRuntime::isStandaloneInitPhase()instead of the broadshouldDeferHeavyStreamIoEmittersbag (peer php-in-php: drop shouldDeferHeavyStreamIoEmitters from StreamRead/Lifecycle/Bucket/Filter — thin via isThinStandaloneAotMain (#1492) #20553).ContextStandaloneBodiesRuntimeShrinkTestso Context never re-imports the StreamIo defer bag.C / defer shrink: removed the last
StreamIoRuntime::shouldDeferHeavyStreamIoEmitterscall site fromlib/JIT/Context.php(string-helper block). Observable init-phase skip unchanged.Closes #20571
Test plan
vendor/bin/phpunit test/unit/ContextStandaloneBodiesRuntimeShrinkTest.php— OK (2 tests)vendor/bin/phpunit test/unit/FileGetContentsRuntimeShrinkTest.php— OKExamplesHelloWorldAotRegressionTestContext/StreamIo assertion filters — OKphp script/bootstrap-inventory.php --check— OK 5679/5679make bootstrap-selfhost-vm-driver-execute-probe— OKVerification transcript
Made with Cursor