php-in-php: gate JitEnv putenv thin AOT on isThinStandaloneAotMain (#20499) - #20500
Merged
Conversation
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamIoRuntime::shouldDeferHeavyStreamIoEmittersfromext/standard/JitEnv.phpputenv paths; gate libc-only thin AOT onContext::isThinStandaloneAotMain()(peer php-in-php: drop shouldDeferHeavyStreamIoEmitters from ObOutputJitBridge — thin via isThinStandaloneAotMain (#1492) #20443 / php-in-php: delete JitGetenvKernel libc defer — always JitVmHelperLink + GetenvJitHelper PHP (#1492) #20156).standaloneInitPhasecan now NestedJITGetenvJitHelper::putenvwhen not thin-standalone; thin user-script AOT keeps libc-only (AOT: fix request_parse_body compile/link (#5965) #17316).test/unit/PutenvRuntimeShrinkTest.phpshrink guard.Closes #20499
Lines removed / shrunk
ext/standard/JitEnv.php: removeduse StreamIoRuntime+ 2shouldDeferHeavyStreamIoEmitters()call sites (replaced withisThinStandaloneAotMain()).php-src reference
ext/standard/basic_functions.c—zif_putenv/zif_getenvTest plan
vendor/bin/phpunit test/unit/PutenvRuntimeShrinkTest.php— OK (2 tests)vendor/bin/phpunit test/unit/GetenvJitRuntimeShrinkTest.php— OKvendor/bin/phpunit test/unit/EnvLocalRuntimeShrinkTest.php— OKmake bootstrap-selfhost-vm-driver-execute-probe— OKVerification transcript
Made with Cursor