Repository navigation
Stdlib: getenv() scalar name coercion without strict_types (#4177) - #20281
Merged
Merged
Conversation
Match php-src Z_PARAM_STR_OR_NULL: coerce int/float/bool when the caller is not strict_types; keep TypeError under declare(strict_types=1) (#17765). Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getenv($name)now follows php-src Z_PARAM_STR_OR_NULL with callerstrict_typesparity: coerce int/float/bool when the caller is not strict; TypeError underdeclare(strict_types=1)(Regression: getenv(bool/int) coerces to string — TypeError missing (ext/standard/basic_functions.c, re-#4177) #17765 tests unchanged).VmString::typedNullableStringBuiltinArgForFrame; JIT usesJitStringBuiltinArg::lowerStrictOrCoercible(..., '?string').putenv()/fread()already matched Zend; enum TypeError message for getenv now says?stringlike Zend.Closes #4177
php-src reference
ext/standard/basic_functions.c—zif_getenvgetenv(?string $name = null, bool $local_only = false)Verification
Note: pre-existing AOT
getenv_all/getenv_local_onlyfixture failures reproduce without this JIT change (zero-arg / string-literal paths).Made with Cursor