Skip to content

php-in-php: drop UserScriptAotDeferNestedJit from StringBin2hex (#20011) - #20019

Merged
PurHur merged 1 commit into
masterfrom
agent/runtime-php-bin2hex-defer
Jul 17, 2026
Merged

PurHur merged 1 commit into
masterfrom
agent/runtime-php-bin2hex-defer

Conversation

@PurHur

@PurHur PurHur commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove UserScriptAotDeferNestedJit from StringBin2hex; thin hex via Context::isThinStandaloneAotMain() + existing JitBin2hexKernel.
  • Embed / non-thin path still JitVmHelperLink::ensureBridge → Bin2hexJitHelper PHP.
  • Pre-link bin2hex in ensureMinimalUserStandaloneBodies (same as readfile).

C / defer surface

  • Deleted: UserScriptAotDeferNestedJit import + shouldDefer() gate from StringBin2hex (−1 defer call site).
  • Kept: thin JitBin2hexKernel hex loop (not libc; no new C).

Verification

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
vendor/bin/phpunit test/unit/Bin2hexRuntimeShrinkTest.php
vendor/bin/phpunit test/aot/AotTest.php --filter "bin2hex\.phpt"
php script/bootstrap-inventory.php --check
php script/check-selfhost-spine-coverage-sync.php
make bootstrap-selfhost-vm-driver-execute-probe
'
  • Shrink: OK (3 tests, 26 assertions)
  • AOT bin2hex.phpt: OK
  • inventory: OK 5347/5347; spine sync OK; vm-driver-probe OK
  • Note: bin2hex_hex2bin_enum_typeerror AOT still fails on master via StringHex2bin nested JIT (Object_::compileStaticPropertyIsSet TypeError) — pre-existing, not this PR.

Closes #20011

Made with Cursor

Route thin standalone AOT through isThinStandaloneAotMain + JitBin2hexKernel
(same shape as #19966 readfile); embed keeps Bin2hexJitHelper via JitVmHelperLink.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

php-in-php: drop UserScriptAotDeferNestedJit from StringBin2hex — thin hex via isThinStandaloneAotMain (#1492)

1 participant