Repository navigation
Stdlib: XMLReader moveToAttribute/moveToElement/next (#19395) - #19867
Merged
Merged
Conversation
Implement attribute-cursor and sibling-skip APIs in PHP-in-PHP (VmXmlReader) to match php-src xmlTextReaderMoveTo* / xmlTextReaderNext semantics. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XMLReader::moveToAttribute,moveToFirstAttribute,moveToNextAttribute,moveToElement, andnext([string $name])in PHP-in-PHP (VmXmlReader+ attribute cursor onXmlReaderState).ext/xmlreader/php_xmlreader.c/ libxmlxmlTextReaderMoveTo*+xmlTextReaderNext.Closes #19395
php-src reference
Test plan
php bin/vm.php test/repro/maintainer_gap_xmlreader_move_next.php— matches Zendphp bin/jit.php test/repro/maintainer_gap_xmlreader_move_next.php— same./script/phpunit.sh --filter 'XmlReaderTest|move_to_attribute_next'— OKphp script/bootstrap-inventory.php --check— OK 5295/5295Notes
runtime/*.c.north-star5-faststill red on master (native execute exit 134) — recorded on Strategic alignment: compiler excellence pillars (2026 H2) #10533.Made with Cursor