Repository navigation
Stdlib: sem_get() auto_release bool + int coerce (#19515) - #19523
Merged
Merged
Conversation
Parse auto_release as Z_PARAM_BOOL (int/float coerce), pass bool to host under strict_types, and wire Plus+$true call-arg producers so $key+1,…,true works. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sem_get()$auto_releaseto match php-src stub (bool, Z_PARAM_BOOL coerces int) instead of rejecting both1andtrueunderstrict_typeshost delegation (Regression: sem_get() auto_release — rejects int coerce and bool (re-#3704, ext/sysvsem/sysvsem.c) #19515).permissions,bool $auto_release) viaphp-types-sem-get-auto-release-bool.patch.true/false/nullcall-arg producer wiring sosem_get($key + 1, …, true)does not scramble args.php-src reference
ext/sysvsem/sysvsem.c/sysvsem.stub.php—bool $auto_release = truePHP implementation
ext/sysvsem/SemArgs.php—parseOptionalBoolCoerce()ext/sysvsem/sem_get.php,VmSem.phplib/Compiler.php— arith + hoisted scalar ConstFetch producer inclusionlib/BuiltinParamNames.php, InternalArgInfo patchTest plan
Output (both):
SysvSemaphore/SysvSemaphore/permissions auto_release boolphp -d memory_limit=1536M vendor/bin/phpunit --filter SysvSemBuiltinTest— OK (2 tests)Closes #19515
Made with Cursor