php-in-php: move StringVarExportUserScriptLlvm to JitVarExportKernel (#19430) - #19437
Merged
Conversation
This was referenced Jul 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__compiler_var_exportbridge fromlib/JIT/Builtin/StringVarExportUserScriptLlvm.phpintoext/standard/JitVarExportKernel.php(kernel-quarantine pattern php-in-php: move StringHtmlspecialcharsUserScriptLlvm → JitHtmlspecialcharsKernel in ext/standard (#1492) #19389/php-in-php: move PregMatchUserScriptLlvm stubs → JitPregMatchKernel in ext/standard (#1492) #19399).StringVarExportdefer path now callsJitVarExportKernel::implement; embed/full path unchanged viaVarExportJitHelper.LOC: deleted
lib/JIT/Builtin/StringVarExportUserScriptLlvm.php(~87 LOC); addedext/standard/JitVarExportKernel.php(net shrink of JIT-builtin surface).Closes #19430
Test plan
./script/phpunit.sh --filter VarExportRuntimeShrinkTest→ OK (4 tests)./script/phpunit.sh test/compliance/VarExportVMTest.php→ OK (5)./script/phpunit.sh test/compliance/VarExportJITTest.php→ OK (2)php script/bootstrap-inventory.php --check→ OK 5051/5051php script/check-selfhost-spine-coverage-sync.php→ OKmake bootstrap-selfhost-vm-driver-execute-probe→ OKNote: standalone
var_exportAOT currently segfaults afterc:main_before_phpon master as well (embed +PHP_COMPILER_AOT_USER_SCRIPT); HelloWorld AOT OK. Not introduced by this quarantine.Verification transcript
Made with Cursor