Repository navigation
Stdlib: add ext/fileinfo finfo_* MIME sniff (#3366) - #19239
Merged
Merged
Conversation
Register fileinfo module with FILEINFO_* constants, finfo class, and procedural finfo_open/file/buffer/close/set_flags using VmMime byte sniff (PHP-in-PHP, VM-first; JIT deferred). Co-authored-by: Cursor <cursoragent@cursor.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/fileinfomodule:FILEINFO_*constants,finfoclass, andfinfo_open/finfo_file/finfo_buffer/finfo_close/finfo_set_flagsVmFinfo+ existingVmMime::detectFromBytes()(no new C runtime); JIT deferred (VM-only v1)php-src ref:
ext/fileinfo/fileinfo.c,fileinfo.stub.phpCloses #3366
Test plan
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro/maintainer_gap_finfo_mime.php'./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter finfo_mime test/compliance/VMTest.php'./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && ./script/check-generated-docs.sh'php script/check-selfhost-spine-coverage-sync.php+php script/bootstrap-inventory.php --checkVerification transcript
Made with Cursor