Repository navigation
Session: fix session_id('') clear + PHPT headers-sent guards (#17707) - #19226
Merged
Merged
Conversation
After #17707, session builtins correctly honor headers_sent like Zend; stale compliance fixtures echoed before session_start/session_name/ini_set. Add ob_start() or reorder ini_set before output, align sid_length expect to 26, and fix VmSession::setId('') to clear internal id (JIT mirror). php-src: ext/session/session.c — PS(session_id), SG(headers_sent) Verification: PHP_COMPILER_PROFILE=8.4 ./vendor/bin/phpunit test/compliance/VMTest.php --filter session # OK (45 tests, 45 assertions) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_id('')to clear the internal session id while returning the previous id (php-srcext/session/session.c); mirror in JITSessionId::emitSetFromStringempty branch.ob_start()or reorderini_setbefore output, updatesession_regenerate_idsid length 32→26, align warning/EXPECT ordering with harness stderr merge.php-src reference
ext/session/session.c—PS(session_id),php_session_start()+SG(headers_sent)PHP implementation
ext/standard/VmSession.php—setId('')clears$idlib/JIT/Builtin/SessionId.php— empty-set clears id buffertest/compliance/cases/stdlib/session*.phpt— headers-sent-safe fixturesVerification
Closes #17707 (follow-up: PHPT +
session_id('')parity)Made with Cursor