php-in-php: delete EnvironMirrorRuntimeUserScriptCstr — helper-runtime + libc native mirror (#19157) - #19168
Merged
Conversation
…e + libc native mirror (#19157) Route all environ mirror paths through JitVmHelperLink + EnvironMirrorNativeJitHelper with init-safe phpc_native_environ_mirror_into_ht (libc walk SSOT in EnvironLibcWalkJit). Removes ~182 LOC UserScriptCstr defer branch; prelinks helper-runtime unit. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnvironMirrorRuntimeUserScriptCstr.php(~182 LOC libc environ LLVM defer path) and route all user-script/embed paths throughJitVmHelperLink+EnvironMirrorNativeJitHelper.VmEnvEnvironNative::mirrorIntoNativeHashtable()→phpc_native_environ_mirror_into_ht→ sharedEnvironLibcWalkJit(libc environ walk into native__hashtable__*).ext/standard/EnvironMirrorNativeJitHelper.phphelper-runtime unit for cold-start user-script AOT.C runtime shrink
lib/JIT/Builtin/EnvironMirrorRuntimeUserScriptCstr.php(182 LOC dedicated defer LLVM)EnvironLibcWalkJit.php(shared JIT helper) + thinphpc_native_environ_mirror_into_htinternalNet: dedicated user-script-only defer branch deleted; libc walk consolidated behind PHP internal callable from compiled helper.
php-src reference
sapi/cli/php_cli.c— copy environ into superglobals on CLI startupVerification
Closes #19157
Made with Cursor