Stdlib: mb_convert_encoding() array|string source operand (#3222) - #19084
Merged
Merged
Conversation
Implement php-src array batch conversion for mb_convert_encoding() and use array|string in enum TypeError messages. Adds compliance + repro guards. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mb_convert_encoding()array source operand: convert string elements in place, preserve non-string scalars and keys (php-srcext/mbstring/mbstring.c).TypeErrorwith Zendarray|stringexpected type (php-src-strict).php-src reference
ext/mbstring/mbstring.c—PHP_FUNCTION(mb_convert_encoding)array branchPHP implementation
ext/mbstring/VmMbstring.php—convertEncodingSourceArray()ext/mbstring/mb_convert_encoding.php— array vs string dispatchVerification
Closes #3222 (array batch slice; iconv/mb_convert_encoding base APIs already registered).
Made with Cursor