M2: lib spine VM -r smoke gate (#1846) - #1850
Merged
Merged
Conversation
Wire PHP_COMPILER_VM_SPINE_SMOKE on the existing compiler_lib_spine_smoke AOT binary so native runs exercise vm_run_smoke echo before M5 bin/vm.php. Adds bootstrap script, Makefile target, wave-check flag, and opt-in CI hook. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BOOTSTRAP_LIB_SPINE_VM_SMOKE=1 make bootstrap-selfhost-lib-spine-vm-smoketo runvm_run_smoke(echo "vm-spine-ok") on the existingbuild/selfhost-lib-spine-smokeartifact.compiler_lib_spine_smoke/main.phpwithPHP_COMPILER_VM_SPINE_SMOKEdispatch and skips argv driver incli_driver.phpfor native runs.BOOTSTRAP_LIB_SPINE_VM_SMOKE_GATE=1inci-local.shllvm tail; wave-check--with-lib-spine-vm-smoke.Test plan
vendor/bin/phpunit --filter BootstrapLibSpineVmSmokeTest(Docker)BOOTSTRAP_LIB_SPINE_VM_SMOKE=1 make bootstrap-selfhost-lib-spine-vm-smoke(requires LLVM 9 native link green)BOOTSTRAP_LIB_SPINE_VM_SMOKE=1 ./script/bootstrap-wave-check.sh --with-lib-spine-vm-smokeCloses #1846
Made with Cursor