Testing: MiniWebAppJitProjectTest PATH_INFO hello + contact POST (#1759) - #1841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1759.
Extends
MiniWebAppJitProjectTest(phase 2 of #587) with two JIT project smokes that mirror existing VM/AOT coverage:MiniWebAppCgiEnv::pathInfoHello('Dev'), assertsHello DevMiniWebAppCgiEnv::postQueryRouteContact(), assertsThank you, PostDevReuses shared CGI helpers (no duplicated env strings). On JIT compile failure,
runIndex()skips with an explicitnot jittablemessage (#475, #58) instead of a bare non-zero exit.Test plan
On this Runforge harness,
jit-runtime-probe.phpsegfaults (bin/jit.php -lexit 139), so all three tests skip insetUpwith the existing MCJIT probe message — acceptable per #1759 acceptance (pass or explicit skip). On hosts with a working LLVM MCJIT probe, all three routes should assert.Made with Cursor