M2 spine: VmSplAutoload AOT-safe runners + usort/uasort (582/586) - #1827
Merged
Conversation
PurHur
force-pushed
the
agent/stdlib-vmsplautoload
branch
from
May 25, 2026 00:32
5d4234a to
abd1ba0
Compare
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VmSplAutoloadto useSplAutoloadRunner/SplAutoloadFunctionRunner/SplAutoloadInstanceMethodRunnerinstead of anonymous closures so the unit passes AOT lint in the self-host spine (noExpr_Closure).VmSplAutoload.php,usort_.php, anduasort_.phptocompiler_lib_spine_smoke(579 → 582 / 586 inventory).Closes #1543
Closes #1821
Part of #1492 (North Star 2; was #1056)
Test plan
php bin/compile.php -l ext/standard/VmSplAutoload.phpphp bin/compile.php -l test/selfhost/compiler_lib_spine_smoke/main.php(afterscript/apply-patches.sh)vendor/bin/phpunit --filter BootstrapSelfhostBundleTestvendor/bin/phpunit --filter SplAutoloadRegisterTestphp script/check-m2-spine-issue-hygiene.phpWAVE3_ROADMAP_SYNC_GATE=1 vendor/bin/phpunit --filter Wave3RoadmapSyncTestphp-compiler:22.04-dev, tar pipe): above tests greenDeferred to M4:
bin/vm.php,src/cli.php(4 files remain for 586/586).Made with Cursor