Stdlib: encoding/binary builtins reject null via typed string guards (#18252) - #18257
Merged
Merged
Conversation
…18252) Switch bin2hex/base64_encode/quoted_printable_encode/decode VM and JIT lowering to coerceTypedStringBuiltinArg / lowerTypedString so null operands TypeError like Zend instead of coercing to empty string. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin2hex,base64_encode,quoted_printable_encode, andquoted_printable_decodeVM paths fromVmString::coerceStringBuiltinArgtocoerceTypedStringBuiltinArgso null operands throwTypeErrorlike Zend PHP 8.2+.JitStringBuiltinArg::lowerTypedString(same pattern as closed Regression: typed string builtins — null $string coerced to '' not TypeError (ext/standard/string.c, ext/standard/url.c) #18190urlencode/htmlspecialchars).ext/standard/+ sharedJitStringBuiltinArgguards.Closes #18252
php-src reference
ext/standard/string.c—php_bin2hex,php_quoted_printable_encode/decodeext/standard/base64.c—php_base64_encodeVerification
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro/maintainer_gap_encoding_binary_null.php'./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/jit.php test/repro/maintainer_gap_encoding_binary_null.php'Same output (JIT agrees).
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter encoding_null'Made with Cursor