ext/dom: DOMElement::tagName slot init for JIT/AOT (#3326) - #17903
Merged
Merged
Conversation
Register tagName on DOMElement and populate it alongside nodeName so JIT/AOT property-slot reads match VM DomNodePropertySupport parity. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tagNameonDOMElementclass metadata and initialize the slot increateElement()/createElementNS()alongsidenodeName.$el->tagNameaftercreateElement()(previously unset while VM usedDomNodePropertySupportbridge).php-src reference
ext/dom/node.c—dom_node_tag_name_read/ elementtagNamepropertyPHP implementation
ext/dom/VmDom.php— class registration + createElement slot initVerification
Closes #3326 (partial — tagName slot parity; load/loadHTML AOT bridge still tracked on issue).
Made with Cursor