Skip to content

mbstring: mb_language() / mb_http_input() encoding metadata (#4636) - #17870

Merged
PurHur merged 1 commit into
masterfrom
agent/issue-4636-mb-language-http-input
Jul 11, 2026
Merged

PurHur merged 1 commit into
masterfrom
agent/issue-4636-mb-language-http-input

Conversation

@PurHur

@PurHur PurHur commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Summary

php-src reference

  • ext/mbstring/mbstring.cPHP_FUNCTION(mb_language), PHP_FUNCTION(mb_http_input)

PHP implementation

  • ext/mbstring/mb_language.php, mb_http_input.php
  • ext/mbstring/MbstringLanguageRegistry.php, MbstringState.php

Verification

source script/php-env.sh
php bin/vm.php test/repro/maintainer_gap_mb_language_http_input.php
# ok

./vendor/bin/phpunit --filter mb_language_http_input
# OK (2 tests, VM+JIT)

php script/check-selfhost-spine-coverage-sync.php
# OK (4414/4414)

./script/ci-fast.sh
# exit 0

Closes #4636

Made with Cursor

Wire NLS language getter/setter and HTTP input encoding probe through
MbstringState with php-src-aligned ValueError paths. Completes the
encoding-metadata slice of ext/mbstring for VM parity.

php-src: ext/mbstring/mbstring.c
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stdlib: mb_internal_encoding() / mb_language() / mb_http_input() — encoding defaults (ext/mbstring parity)

1 participant