Repository navigation
mbstring: fix mb_ucfirst_lcfirst.phpt eszett probe (#17609) - #17815
Merged
Merged
Conversation
Line 10 called mb_lcfirst('ßtraße') but expected mb_ucfirst SS expansion
(SStraße). Align call with expect so compliance matches php-src UTF-8
sharp-s title case behavior.
Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/compliance/cases/mbstring/mb_ucfirst_lcfirst.phpt: line 10 calledmb_lcfirst('ßtraße')but--EXPECT--requiredSStraße(Unicode sharp-s upper expansion frommb_ucfirst, not lcfirst).VmMbstring::ucfirst()/Utf8CaseMap::UPPER_EXPANSION[0xDF]was already correct; only the PHPT call site was wrong.php-src reference
ext/mbstring/mbstring.c—php_mb_ulcfirst/mb_ucfirst(MB_CASE_TITLE on first codepoint; ß → SS)Verification
Closes #17609 (compliance regression from merged #17614 PHPT typo)
Made with Cursor