Skip to content

Stdlib: exception previous-chain compliance guard (#5104) #17712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PurHur merged 1 commit into from
Jul 10, 2026
Merged

Stdlib: exception previous-chain compliance guard (#5104) #17712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions test/compliance/cases/stdlib/exception_previous_chain.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
--TEST--
Stdlib: Exception three-arg ctor + getPrevious() chain (#5104, zend_exceptions.c)
--FILE--
<?php
declare(strict_types=1);

$inner = new Exception('inner');
$outer = new Exception('outer', 0, $inner);

$prev = $outer->getPrevious();
echo 'previous_is_exception=', ($prev instanceof Exception) ? 'true' : 'false', "\n";
echo 'previous_message=', $prev instanceof Exception ? $prev->getMessage() : 'null', "\n";
echo 'inner_previous_null=', (null === $inner->getPrevious()) ? 'true' : 'false', "\n";

$chain = (string) $outer;
echo 'chain_has_next=', (str_contains($chain, 'Next Exception')) ? 'true' : 'false', "\n";
echo 'chain_has_inner=', (str_contains($chain, 'inner')) ? 'true' : 'false', "\n";
echo 'chain_has_outer=', (str_contains($chain, 'outer')) ? 'true' : 'false', "\n";
--EXPECT--
previous_is_exception=true
previous_message=inner
inner_previous_null=true
chain_has_next=true
chain_has_inner=true
chain_has_outer=true
15 changes: 15 additions & 0 deletions test/repro/exception_previous_chain.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?php
declare(strict_types=1);

$inner = new Exception('inner');
$outer = new Exception('outer', 0, $inner);

$prev = $outer->getPrevious();
echo 'previous_is_exception=', ($prev instanceof Exception) ? 'true' : 'false', "\n";
echo 'previous_message=', $prev instanceof Exception ? $prev->getMessage() : 'null', "\n";
echo 'inner_previous_null=', (null === $inner->getPrevious()) ? 'true' : 'false', "\n";

$chain = (string) $outer;
echo 'chain_has_next=', (str_contains($chain, 'Next Exception')) ? 'true' : 'false', "\n";
echo 'chain_has_inner=', (str_contains($chain, 'inner')) ? 'true' : 'false', "\n";
echo 'chain_has_outer=', (str_contains($chain, 'outer')) ? 'true' : 'false', "\n";