Repository navigation
Stdlib: preg_match() compile failure leaves matches [] not null (#17584) - #17623
Merged
Merged
Conversation
Zend keeps the $matches out-parameter as an empty array when pattern compilation fails; the VM wrapper was writing null and broke parity probes for duplicate named subpatterns without PCRE2_DUPNAMES. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preg_match()/preg_match_all()pattern compilation fails, Zend leaves the$matchesout-parameter as an empty array[].$target->null()on failure, somaintainer_gap_preg_match_duplicate_named.phpfailed even though compile rejection andpreg_last_error()were already correct.Root cause
ext/standard/preg_match.phpandpreg_match_all.phpwrotenullinto the by-ref$matchesslot onfalsereturn; php-src keeps the caller's empty array unchanged.php-src reference
ext/pcre/php_pcre.c—php_pcre_pcre2_compile()duplicate-name handling withoutPCRE2_DUPNAMESPHP implementation
ext/standard/preg_match.php,ext/standard/preg_match_all.php— write emptyHashTableon compile failureVerification
Closes #17584
Made with Cursor