Runtime: fix user-script AOT ob stack + system()/passthru() capture (#10492) - #17452
Merged
Merged
Conversation
Route echo through append_bytes instead of direct write, use ObStorageGlobals LLVM ob stack and libc popen shell_exec under UserScriptAotDeferNestedJit, and build exec capture hashtables without nested ProcessExecCaptureNativeJitHelper. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObOutputUserScriptLlvmnow links the exec-capture ob stack and routes echo throughObOutputEchoJitEmit/__phpc_ob_append_bytesinstead ofEmbedObEchoBridgedirectwrite(1,…).ObOutputExecCaptureLlvmimplementsob_start/append_bytes/ob_get_cleanviaObStorageGlobalswhenUserScriptAotDeferNestedJitis active — nestedObOutputExecCaptureJitHelperJIT segfaults in standalone AOT.ProcessShellExecLibcprovides libcpopen/fread__compiler_shell_exec;ProcessExecCaptureLlvmbuilds the capture hashtable with__string__separate(no buffer alias).Fixes AOT segfault in
system_passthru_oband restores php-src behavior for child stdout through active output buffers.Verification
Closes #10492
Made with Cursor