Repository navigation
Fix var_export($obj->method(), true) MethodCall inline arg slot (#17251) - #17262
Merged
Merged
Conversation
When var_export($obj->method(), true) is hoisted with a trailing ConstFetch, both ARG_SEND slots drifted to the true literal; rewireVarExport now detects the literal by name and binds arg #0 to the MethodCall EXEC_RETURN slot. Co-authored-by: Cursor <cursoragent@cursor.com>
Combine methodCallIsStmtLevelDiscardPrelude (master) with rewireVarExport true-literal detection and expanded MethodCall producer-slot coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
var_export($it->current(), true)(andkey()/ generatorcurrent()) when php-cfg hoists a MethodCall producer plus trailingtrueConstFetch: arg #0 was wired to thetrueslot instead of the MethodCallEXEC_RETURNslot.next()beforecurrent()).rewireVarExportNestedInlineCallArgSendSlotsnow detects hoistedtrueby literal name (not constant-pool index) and rewires arg #0 when both sends alias the true slot.php-src reference
ext/standard/var.c—php_var_export_ex()arg #0 receives MethodCall resultZend/zend_compile.c—ZEND_SEND_VAL/ZEND_SEND_VARfor call argsPHP implementation
lib/Compiler.php— sibling ordinal/target-arg index,rewireVarExportNestedInlineCallArgSendSlots,tryFoldHoistedBoolNullLiteralCallArg,resolveAdjacentNestedFuncCallArgSlotTest plan
Closes #17251
Made with Cursor