Repository navigation
Stdlib: ReflectionProperty getHooks string keys + getHook() (#4806) - #17258
Merged
Merged
Conversation
getHooks() returned numeric PropertyHookType indices (0,1) instead of php-src "get"/"set" keys; add getHook(PropertyHookType) returning ReflectionMethod with $prop::get|$prop::set display names. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReflectionProperty::getHooks()now returns an associative array keyed by"get"/"set"(php-srcext/reflection/php_reflection.c), not numericPropertyHookTypebacking indices0/1.ReflectionProperty::getHook(PropertyHookType)returningReflectionMethodwith Zend-style name$prop::get/$prop::set, ornullwhen absent.setHook()— issue repro checked; onlygetHooks/getHookare inphp_reflection.stub.php.php-src reference
ext/reflection/php_reflection.c—ReflectionProperty::getHooks,getHookext/reflection/php_reflection.stub.phpPHP implementation
lib/VM/ReflectionPropertyHookSupport.php— string-key hook map +hookReflectionMethod()lib/VM/Builtin/ReflectionPropertyGetHooks.php—HashTable::add('get'|'set', …)lib/VM/Builtin/ReflectionPropertyGetHook.php— new VM builtinVerification
Closes #4806
Made with Cursor