Repository navigation
php-in-php: base64_encode()/base64_decode() JIT via Base64JitHelper PHP (#17234) - #17236
Merged
Merged
Conversation
…HP (#17234) Route runtime JIT/AOT through Base64EncodeJitHelper and Base64DecodeJitHelper delegating to VmString, with LLVM defer paths for user-script standalone AOT. Hot path no longer emits inline LLVM from JitBase64Encode/JitBase64Decode. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Regenerate bootstrap-inventory/profile and spine footnotes (4229 files). Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base64_encode()/base64_decode()runtime JIT/AOT throughBase64EncodeJitHelper/Base64DecodeJitHelperdelegating toVmString(php-srcext/standard/base64.cSSOT in PHP).lib/JIT/Builtin/StringBase64Encode/StringBase64Decodenested-JIT bridges; retainJitBase64Encode/JitBase64DecodeLLVM only for user-script standalone AOT defer (Stdlib/AOT: standalone binary run segfault (exit 139) after compile — Docker harness JIT-linked builtins #16734).Closes #17234
C runtime shrink
ext/standard/JitBase64Encode.php(204 LOC) andJitBase64Decode.php(233 LOC) retained only for defer/standalone LLVM fallback.Verification
Note:
AotTestenum-casebase64_*_enum_case_type_errorfixtures still fail on master withHashTable::append()during helper-runtime cache hit — pre-existing, unrelated to this bridge.Made with Cursor