Repository navigation
Stdlib: register mt_getrandmax() beside getrandmax() (#17228) - #17235
Merged
Merged
Conversation
Portable code and vendor patches call mt_getrandmax() for the MT19937 upper bound; register the PHP builtin with VM/JIT/AOT constexpr lowering. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 7, 2026
Stdlib: mt_getrandmax() missing while mt_rand()/getrandmax() registered (ext/random/random.c)
#17228
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/standard/mt_getrandmax.php— thin builtin returningVmMt19937::PHP_MT_RAND_MAX(2147483647), matching php-srcext/random/random.cPHP_FUNCTION(mt_getrandmax).ext/standard/Module.phpbesidegetrandmax(); spine + bootstrap inventory updated..phpt(VM + JIT) and issue repro undertest/repro/.Closes #17228
php-src reference
ext/random/random.c—PHP_FUNCTION(mt_getrandmax)Verification
VM repro:
PHPUnit:
OK (4 tests, 4 assertions)(VM + JIT compliance)AOT compile + run:
(ArgumentCountError on surplus args is VM/JIT-only today — same as existing
getrandmax().)Made with Cursor