Repository navigation
Stdlib: gate forward-profile builtins on 8.2 reference profile (#17206) - #17212
Merged
Merged
Conversation
Gate mb_trim, crc32c, hebrevc, attribute_exists, and class_uses_recursive on CompilerVersion forward-profile predicates so unset PHP_COMPILER_PROFILE matches Zend 8.2 function_exists parity; forward profile 8.4 keeps callability. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supports*/advertises*gates inCompilerVersionformb_trim,crc32c,class_uses_recursive,attribute_exists, and newhebrevcwith thesupportsJsonValidatereference-profile pattern so unsetPHP_COMPILER_PROFILEmatches Zend 8.2function_existsparity.hebrevcregistration inext/standard/Module.phpandBuiltinIntrospectionPolicy.test/compliance/cases/stdlib/profile_gate/.php-src reference:
ext/standard/basic_functions.c,ext/standard/crc32.c,ext/standard/string.c,ext/mbstring/mbstring.c.Closes #17206
Verification
Made with Cursor