Language: nullsafe ?-> method call inline arg compile + short-circuit (#17186)

[PurHur]

Summary

• Pass NullsafeMethodCall as $cfgCallOp into compileCallArgSends() so inline argument lowering no longer fatals in outerSiblingInlineCallArgProducerSlot().
• Defer immediately preceding inline arg producers (IIFE FuncCall + Closure) into the nullsafe fetch block so arguments are not evaluated when the receiver is null (Language: nullsafe operator (?->) — short-circuit + error semantics parity #4394 / php-src ?-> short-circuit).

Root cause

compileNullsafeMethodCall() called compileCallArgSends($expr->args, $fetchBlock) without the CFG call op. php-cfg also uses a distinct arg temporary (#6) vs the inline producer result (#5), so the existing prelude deferral slice never matched IIFE arguments.

php-src reference

• Zend/zend_compile.c — nullsafe method call compile; argument evaluation only on non-null receiver branch

PHP implementation

• lib/Compiler.php — compileNullsafeMethodCall, deferred nullsafe prelude scan, isNullsafeMethodCallArgPreludeProducer()

Verification

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
vendor/bin/phpunit --filter "nullsafe_method_args_short_circuit|nullsafe_chain_method"
php bin/vm.php test/repro-maintainer/nullsafe_method_args.php
php test/repro-maintainer/nullsafe_method_args.php'

PHPUnit OK (2 tests, 2 assertions)
VM: NULL / call / 2  (matches Zend)

Closes #17186

Made with Cursor