Repository navigation
Stdlib: strict_types null operands — password/microtime/date (#17050–#17052) - #17053
Merged
Merged
Conversation
–#17052) Wire stringBuiltinArgForFrame and bool strict-or-coercible lowering so declare(strict_types=1) rejects null operands on password_hash/verify, microtime, and date_create_from_format while non-strict coercion stays intact. Co-authored-by: Cursor <cursoragent@cursor.com>
…date batch Keep master's lowerZParamBool/parseBoolBuiltinArgForFrame for microtime; retain password_hash/verify and date_create_from_format strict null fixes. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
declare(strict_types=1)for null operands onpassword_hash(),password_verify(),microtime(), anddate_create_from_format()— matching php-srcZ_PARAM_STR/Z_PARAM_BOOLstrict verify paths.VmString::stringBuiltinArgForFrame()and newVmMath::parseBoolBuiltinArgForFrame()gate null under strict call sites; non-strict coercion unchanged (Regression: password_hash(null) TypeError — Zend coerces null to empty string (ext/standard/password.c) #17023 / Regression: microtime(null) TypeError — Zend coerces null to false (ext/standard/microtime.c) #17025).JitStringBuiltinArg::lowerStrictOrCoercible()and newJitBoolArg::lowerStrictOrCoercible()mirror the same branch.Closes #17050
Closes #17051
Closes #17049
Closes #17052
php-src reference
ext/standard/password.c—password_hash/password_verifyext/standard/microtime.c—microtimeext/date/php_date.c—date_create_from_formatVerification
Made with Cursor