Repository navigation
Gate grapheme_str_contains/strimwidth on ext/intl for function_exists (#11825) - #16966
Merged
Merged
Conversation
…#11825) Zend only advertises intl grapheme helpers when ext/intl is loaded; forward-profile registration stays callable but introspection now matches php-src for all grapheme_*. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grapheme_str_contains()andgrapheme_strimwidth()were the only intl grapheme helpers still visible tofunction_exists()withoutext/intlloaded on the PHP 8.4 forward profile.IntlExtensionPolicy::advertisesBuiltins()inBuiltinIntrospectionPolicy, matchinggrapheme_strlen/grapheme_str_splitand php-srcext/intl/php_intl.cmodule registration.php-src reference
ext/intl/php_intl.c— grapheme helpers registered only with loaded intl moduleext/standard/basic_functions.c—function_exists()/ internal function tablePHP implementation
ext/standard/BuiltinIntrospectionPolicy.php— intl gate forgrapheme_str_contains/grapheme_strimwidthfunction_exists()already delegates to the same policy viaJitFunctionExists/FunctionExistsJitHelperVerification
Closes #11825
Made with Cursor