Repository navigation
Language: allow LazyGhostTrait in trait-const compile check (#6606) - #16958
Merged
Merged
Conversation
TraitClassConstConflictCheck treated builtin LazyGhostTrait as missing when composing classes that use the PHP 8.4 marker trait, breaking getLazyPropertyNames() compliance and unit tests. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TraitClassConstConflictChecknow recognizes builtinLazyGhostTraitwhen verifying trait constant composition.Trait "LazyGhostTrait" not foundfor classes using the PHP 8.4 lazy-ghost marker trait.Root cause
The trait-const conflict pass only indexed traits declared in the compile unit. Builtin
LazyGhostTrait(registered in VM context at runtime) has no constants but was rejected before class compilation could proceed.php-src reference
Zend/zend_traits.c— builtin lazy ghost trait markerext/reflection/php_reflection.c—ReflectionClass::getLazyPropertyNames()(Stdlib: ReflectionClass::getLazyPropertyNames() — PHP 8.4 lazy property introspection missing (ext/reflection/php_reflection.c) #6606)Verification
Closes #6606
Made with Cursor