Stdlib: ReflectionClass::getMethods() IS_STATIC filter parity (#4480) - #16701
Merged
Merged
Conversation
methodMatchesReflectionFilter now maps static/final/abstract method flags via cfgMethodFlagsToReflectionModifiers so IS_STATIC filter matches Zend. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Jul 6, 2026
#16706) Regenerate docs/bootstrap-inventory.md after VmReflection method count drift (#16701). Enable display_errors in file_stat_null_coerce.phpt so rename(null) E_WARNING is captured on stdout per php-src PHPT semantics (deprecations masked). Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReflectionClass::getMethods()filter handling:IS_STATIC(and final/abstract flags) now derive from method visibility viacfgMethodFlagsToReflectionModifiersinstead of visibility-only matching..phptguard.Root cause
collectClassMethodsForReflection()usedmatchesReflectionVisibilityFilter(), which never set the static bit when evaluating filter masks —IS_STATIC-only queries returned an empty list.php-src reference
ext/reflection/php_reflection.c—zim_ReflectionClass_getMethodsVerification
Closes #4480
Made with Cursor