Repository navigation
Stdlib: openssl_pkey_new/get_private/export lifecycle (#6295) - #16593
Merged
Merged
Conversation
…FI (#6295) Wire RSA key generation and PEM import/export through VmOpensslPkeyNative, register OPENSSL_KEYTYPE_* constants, and mark openssl_pkey_export out param by-reference so Zend-parity lifecycle works on VM. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
Resolve generated-doc conflicts by taking master; spine sync remains green. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openssl_pkey_new(),openssl_pkey_get_private(), andopenssl_pkey_export()inext/openssl/using libcrypto FFI (VmOpensslPkeyNative) — php-src reference:ext/openssl/xp.c.OPENSSL_KEYTYPE_*constants andOpenSSLAsymmetricKeywrapping viaVmOpensslObjects::wrapKey().openssl_pkey_exporttoBuiltinByRefParamsso the PEM out-parameter binds by reference (same pattern asopenssl_sign).Root cause
openssl_pkey_newwas a stub throwingLogicException; export/get_private were unregistered. By-ref export arg was missing fromBuiltinByRefParams, so$outstayed empty despite a successful export.Verification
Closes #6295
Made with Cursor