Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ext/standard/VmStreamMeta.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public static function buildMetaArray(string $uri, $fp = null, ?bool $eofOverrid
|| \str_starts_with($uri, 'php://fd/');

$socketType = self::streamTypeForUri($uri);
$phpNativeStreamType = self::phpNativeStreamType($uri);
$eof = null !== $eofOverride ? $eofOverride : \feof($fp);
$reportedMode = null !== $mode ? $mode : self::defaultReportedMode($uri, $isPhpMemory);

Expand All @@ -31,7 +32,7 @@ public static function buildMetaArray(string $uri, $fp = null, ?bool $eofOverrid
'blocked' => $blocked ?? true,
'eof' => $eof,
'unread_bytes' => 0,
'stream_type' => $socketType ?? ($isPhpMemory ? 'MEMORY' : ($isPhp ? 'STDIO' : 'STDIO')),
'stream_type' => $socketType ?? $phpNativeStreamType ?? ($isPhp ? 'STDIO' : 'STDIO'),
'mode' => $reportedMode,
'seekable' => true,
'uri' => $uri,
Expand Down Expand Up @@ -205,6 +206,21 @@ public static function isSocketTransport(string $uri): bool
return null !== self::streamTypeForUri($uri);
}

/**
* php-src stream_type for php://memory / php://temp / php://fd (main/streams/php_stream_memory.c, php_stream_temp.c).
*/
public static function phpNativeStreamType(string $uri): ?string
{
if (\str_starts_with($uri, 'php://temp')) {
return 'TEMP';
}
if (\str_starts_with($uri, 'php://memory') || \str_starts_with($uri, 'php://fd/')) {
return 'MEMORY';
}

return null;
}

/**
* php-src stream_type strings for socket transports (ext/standard/streams.c; #6203, #8202).
*/
Expand Down
15 changes: 15 additions & 0 deletions test/compliance/cases/stdlib/stream_get_meta_data_temp.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
stream_get_meta_data() on php://temp — stream_type TEMP not MEMORY (#16577, ext/standard/streams.c)
--FILE--
<?php

declare(strict_types=1);

$h = fopen('php://temp', 'r+');
$meta = stream_get_meta_data($h);
echo isset($meta['stream_type']) && $meta['stream_type'] === 'TEMP' ? '1' : '0', "\n";
echo isset($meta['wrapper_type']) && $meta['wrapper_type'] === 'PHP' ? '1' : '0', "\n";
fclose($h);
--EXPECT--
1
1
13 changes: 13 additions & 0 deletions test/repro/maintainer_gap_stream_get_meta_data_temp_type.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

declare(strict_types=1);

$fp = fopen('php://temp', 'r+');
if (false === $fp) {
echo "fail\n";
exit(1);
}
$meta = stream_get_meta_data($fp);
$type = $meta['stream_type'] ?? '';
fclose($fp);
echo 'TEMP' === $type ? "ok\n" : "fail:{$type}\n";
32 changes: 32 additions & 0 deletions test/unit/VmStreamMetaRuntimeShrinkTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,38 @@ public function testVmStreamMetaDoesNotReferenceHostStreamSetBlocking(): void
$this->assertStringNotContainsString('\\stream_set_blocking(', $source);
}

public function testBuildMetaArrayForPhpTempStream(): void
{
$handle = VmFs::fopen('php://temp', 'r+');
$this->assertNotFalse($handle);
$meta = VmFs::streamGetMetaData($handle);
$this->assertInstanceOf(\PHPCompiler\VM\HashTable::class, $meta);
$streamType = null;
foreach ($meta->iterateKeyed(false) as [$keyVar, $value]) {
if (Variable::TYPE_STRING === $keyVar->type && 'stream_type' === $keyVar->toString()) {
$streamType = $value->toString();
}
}
$this->assertSame('TEMP', $streamType);
VmFs::fclose($handle);
}

public function testBuildMetaArrayForPhpMemoryStream(): void
{
$handle = VmFs::fopen('php://memory', 'r+');
$this->assertNotFalse($handle);
$meta = VmFs::streamGetMetaData($handle);
$this->assertInstanceOf(\PHPCompiler\VM\HashTable::class, $meta);
$streamType = null;
foreach ($meta->iterateKeyed(false) as [$keyVar, $value]) {
if (Variable::TYPE_STRING === $keyVar->type && 'stream_type' === $keyVar->toString()) {
$streamType = $value->toString();
}
}
$this->assertSame('MEMORY', $streamType);
VmFs::fclose($handle);
}

public function testBuildMetaArrayForPlainFilePath(): void
{
$fp = fopen('php://memory', 'r+');
Expand Down