Fix AOT compile SIGSEGV: standalone var_dump/print_r LLVM path (#16565) - #16573
Merged
Merged
Conversation
…6565) Nested JIT compile of VarDumpJitHelper/PrintRJitHelper pulls VmVarDump/VmPrintR and crashes LLVM 9 during user-script AOT builds. Route LOAD_TYPE_STANDALONE through the restored StringVarDumpJit/StringPrintRJit monoliths; embed/self-host keeps the php-in-PHP VarDumpJitHelper bridge. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StringVarDumpJit/StringPrintRJitand routed standalone AOT through nested JIT compile ofVarDumpJitHelper.php/PrintRJitHelper.php. That pulls inVmVarDump/VmPrintRand SIGSEGVs LLVM 9 duringbin/compile.php/phpc build(exit 139).StringVarDump/StringPrintR:LOAD_TYPE_STANDALONE(user AOT): restored LLVM monoliths (StringVarDumpJit,StringPrintRJit)LOAD_TYPE_EMBED(self-host/MCJIT): php-in-PHPVarDumpJitHelper/PrintRJitHelperbridge unchangedlib/AOT/runtime/still onlyphpc_progress.c)Closes #16565
Verification
Note:
FunctionStaticJitCompileTest/phpunit --filter FunctionStaticstill SIGSEGV on master (pre-existing LLVM issue in function-static init path; separate from var_dump nested compile).Made with Cursor