Repository navigation
Fix var_dump multi-arg hoisted sibling producer misbind (#16254, #16269, #13829) - #16466
Merged
Merged
Conversation
…, #13829) Restore correct firstSibling chain start when php-cfg hoists N stmt-level FuncCall producers before a multi-arg consumer, and exclude array pointer mutators from outer producer lists so var_export(key()) wires key() not next(). Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
firstSiblingInlineFuncCallProducerIndextrimming the leftmost hoisted producer when php-cfg lowersvar_dump(strlen($s), substr($s, 0, 2))andvar_dump(ftell($f), fgetc($f))after stmt-level stream calls — each arg now gets its ownFUNCCALL_EXEC_RETURNslot (Regression: var_dump() multi-arg — nested builtin calls misbind first arg slot (re-#11144, ext/standard/var.c) #16254, Stdlib: var_dump() multi-arg — gettype() operand dumps as resource not string (ext/standard/var.c) #16269).next/prev/reset/end/pos) from outer sibling producer lists sovar_export(key($a), true)afternext($a)wireskey()notnext()(Regression: key() string-concat nested operand — returns true not key (ext/standard/array.c) #13829).lib/Compiler.phpproducer-slot wiring; noruntime/changes.php-src reference:
ext/standard/var.c(php_var_dump),ext/standard/array.c(php_next,php_key).Test plan
Verification output (VM):
Closes #16254
Closes #16269
Closes #13829
Made with Cursor