Stdlib: sort() enum arrays use object-handle order like Zend (#5691) - #16439
Merged
Merged
Conversation
php-src SORT_REGULAR compares enum case zvals by stable object handle, not backing scalar value. compareEnumCasesForSort() now matches that transitive ordering so string-backed and non-monotonic int enums sort like php-src array.c. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compareEnumCasesForSort()to use stable enum case object-handle order forsort()/rsort()/asort()/arsort(), matching php-srcphp_array_data_compare_unstable_i/ transitive SORT_REGULAR (PR Fix SORT_REGULAR with new transitive comparison functions php/php-src#20517).Root cause
EnumCaseSupport::compareEnumCasesForSort()usedbackingValueForMinMax()spaceship for backed enums; php-src compares enum zvals by object pointer/handle, not backing value.php-src reference
ext/standard/array.c—php_array_data_compare_unstable_i,php_array_compare_transitivePHP implementation
lib/VM/EnumCaseSupport.php—compareEnumCasesForSort()Verification
Output:
Closes #5691
Made with Cursor