[PurHur]

Summary

Regression re #10778: after $ao->setIteratorClass('ArrayIterator'), var_export($ao->getIteratorClass(), true) wired both call args to the hoisted true literal instead of the MethodCall result — VM echoed 'true' not 'ArrayIterator'.

Root cause: slotForImmediateConstFetchPreludeCallArg() only skipped arg #0 for nested FuncCall producers (nestedFuncCallProducerBeforeTrailingConstFetchPreludes), not sibling MethodCall + ConstFetch patterns like getIteratorClass().

Fix (PHP lowering in lib/Compiler.php)

• Treat MethodCall/StaticCall in sibling call + hoisted scalar const producer matching
• Wire call + ConstFetch arg ordinals by CFG statement order
• Extend nestedFuncCallProducerBeforeTrailingConstFetchPreludes for MethodCall separated by literal prelude

php-src reference

• ext/spl/spl_array.c — spl_array_setIteratorClass / spl_array_getIteratorClass

Verification

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter "ArrayObjectGetIterator|arrayobject_getiterator|arrayobject_iterator_class"'
# OK (5 tests, 5 assertions)

./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_arrayobject_getiterator_after_set.php'
# 'ArrayIterator'

./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_arrayobject_get_iterator_class.php'
# exit 0

Closes #10778

Made with Cursor