Repository navigation
Compiler: fix @settype + var_export(gettype()) arg misbind (#8974) - #16309
Merged
PurHur merged 1 commit intoJul 5, 2026
Merged
Conversation
After a standalone @settype() in an END_SILENCE block, var_export(gettype($x)) incorrectly forwarded the suppress return slot (bool true) instead of the adjacent gettype() result — breaking settype_backed_enum_int compliance. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@settype()in anEND_SILENCEblock,var_export(gettype($x))incorrectly used the@suppress return slot (true) instead of the adjacentgettype()exec-return slot.errorSuppressEndBlockCallArgHasAdjacentNestedFuncCallProducer()guard in both prebind and ARG_SEND paths (lib/Compiler.php).docs/bootstrap-inventory.mdfor the new Compiler helper.Root cause
php-src-strict
@forwarding (#15916) treated the first dead-temp arg of any post-suppress call as the suppressed inner result, even when an immediately preceding siblinggettype()call was the real producer forvar_export().Verification
Output (2026-07-05):
php script/bootstrap-inventory.php --check # OK 4036/4036Closes #8974
Made with Cursor