Add $_GET superglobal support for VM web scripts - #16
Merged
Conversation
Populate query parameters from QUERY_STRING or bin/vm.php -q so compiled pages can read request input like normal PHP. Includes a SimpleWeb example and an integration PHPT with ENV section support in the test harness. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$_GET(and other CGI superglobal names) in the VM by resolving variable operands back to their CFG names and binding them to shared array variables inVM\Context.$_GETfromQUERY_STRINGor the newbin/vm.php -q 'name=value'flag viaPHPCompiler\Web\Superglobals.examples/001-SimpleWeb/example.php, a PHPT integration test (test/real/cases/web_get.phpt), and optional--ENV--lines in PHPT files for the test harness.Context
A small PHP web page needs request parameters (
$_GET), safe output (htmlspecialchars— follow-up), and often multi-fileinclude. This PR covers the first gap so VM mode can run minimal web-style scripts.Test plan
QUERY_STRING='name=World&page=home' php bin/vm.php -r 'echo $_GET["name"];'php bin/vm.php -q 'name=World' examples/001-SimpleWeb/example.phpphp vendor/bin/phpunit test/real/RealWorldTest.php --filter web_getFollow-ups
includein compiled binarieshtmlspecialchars()for escaped HTML output$_POST,$_SERVER, null coalesce (??)Made with Cursor