Repository navigation
Language: ?? merge slot for array dim in func call args (#11603) - #15924
Merged
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11603 —
localeconv()fields looked NULL when read via$lc['decimal_point'] ?? nullinside call arguments (e.g.var_export(..., true)).Root cause: compiler call-arg wiring preferred the hoisted
ArrayDimFetchproducer slot over the stmt-level??merge slot when both preceded the sameFuncCall. Direct offset access and echo paths were already correct.Fix: final
ARG_SENDpass incompileCallArgSends()preferscompileCallArgCoalesceSlot()when a stmt-level coalesce feeds the argument.php-src reference:
Zend/zend_compile.cnull coalesce + call arg evaluation order.PHP implementation:
lib/Compiler.php(no C runtime changes).Verification
Output (issue repro):
Compliance
localeconv_fields.phptalso checksvar_export($items['page'] ?? null, true)→'home'.Closes #11603
Made with Cursor