Stdlib: number_format() optional RoundingMode fifth parameter (#9438) - #15819
Merged
Conversation
Wire PHP 8.4 rounding_mode through VM, JIT, and SprintfJitHelper using VmRoundMode/VmRound SSOT; extend __compiler_number_format ABI for mode int. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Combine master VM rounding_mode scaffolding with JIT phpt, repro guards, and SprintfJitHelper ABI fifth-arg mode forwarding. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$rounding_mode(RoundingMode|int) onnumber_format()— previously rejected withArgumentCountError.VmRoundMode::resolveRoundModeArg()and appliesVmRound::mathRound()inVmNumberFormat::format()(php-srcext/standard/number_format.c/ shared_php_math_number_format_exrounding).JitRoundModeArg→ extended__compiler_number_formatABI →SprintfJitHelper::numberFormat().php-src reference
ext/standard/number_format.c— 5-arg signature withRoundingMode|intext/standard/math.c—_php_math_number_format_ex()/_php_math_round()Verification
Note: Standalone AOT
number_formatlink (__compiler_number_format) remains on deferred inventory stubs (#14811) — same pre-merge master behavior; AOT fixture added for when full StringFormat standalone bodies land.Closes #9438
Made with Cursor