Stdlib: number_format() optional RoundingMode 5th arg (#9438) - #15818
Merged
Conversation
Accept rounding_mode when PHP 8.4 profile is active; delegate to VmRound::mathRound via VmRoundMode SSOT. Extend __compiler_number_format JIT ABI with mode int64. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
number_format($num, $decimals, $dec, $thou, RoundingMode::…)now accepted whenPHP_COMPILER_PROFILE=8.4/ stable 8.4 profile (CompilerVersion::supportsRoundingModeEnum()).VmRoundMode::resolveRoundModeArg()and formats withVmRound::mathRound()inVmNumberFormat::format().__compiler_number_formatABI +SprintfJitHelper::numberFormat()with mode int64;JitRoundModeArglowering for arg Stdlib: floatval, boolval, gettype(null) and expanded PHPT specs #5.php-src reference
ext/standard/number_format.c—_php_math_number_format_ex()5-arg signatureVerification
Closes #9438
Made with Cursor