php-in-php: strcasecmp()/strncasecmp() JIT via CaseCompareJitHelper — drop libc LLVM (#15225) - #15226
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strcasecmp()/strncasecmp()viaCaseCompareJitHelper+StringCaseCompare(pattern fromNaturalCompareJitHelper/ php-in-php: delete StringNaturalCompareJit LLVM — route strnatcmp/strnatcasecmp through NaturalCompareJitHelper PHP (#1492) #13535).StringStrcasecmp::ensureLinked/StringStrncasecmp::ensureLinkedbefore dispatch so libc symbols are replaced by compiled PHP helpers.Closes #15225
C runtime shrink
strcasecmp/strncasecmpsymbols now bridge toVmString::*through compiled PHP instead of libc compare functions on the hot path.php-src reference
ext/standard/string.c—PHP_FUNCTION(strcasecmp|strncasecmp)Test plan
Made with Cursor