Repository navigation
Fix PHP 8.4 builtin registration on 8.4.0-dev forward profile (#15025–#15028) - #15031
Merged
Merged
Conversation
…15028). Use advertisesBuiltinSince() instead of raw version_compare(VERSION, '8.4.0') for class_has_*, str_increment/json_validate, array_find family, RoundingMode, and fpow so -dev profiles register implemented builtins while phantom gates on Zend 8.2 remain via builtinAdvertisementVersion(). Closes #15025 Closes #15026 Closes #15027 Closes #15028 Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supportsClassHasFunctions(),supportsStrIncrement(),supportsJsonValidate(),supportsPhp84ArraySearchFunctions(),supportsRoundingModeEnum(), andsupportsFpow()from rawversion_compare(VERSION, '8.4.0')toadvertisesBuiltinSince()so8.4.0-devforward profile registers implemented builtins.builtinAdvertisementVersion()returning8.2.0on that profile.php-src reference:
ext/standard/basic_functions.c,ext/standard/array.c,ext/standard/string.c,ext/json/php_json.c,ext/standard/basic_functions.stub.php(RoundingMode enum).Test plan
VM repro (all print
ok):AOT lint:
Unit gates:
./vendor/bin/phpunit --filter 'CompilerVersionBuiltinAdvertisementTest|CompilerVersionGateTest' \ test/unit/CompilerVersionBuiltinAdvertisementTest.php test/unit/CompilerVersionGateTest.phpCompliance:
Closes #15025
Closes #15026
Closes #15027
Closes #15028
Made with Cursor