Repository navigation
Bootstrap: sync gen-0 sidecar stamp after #14818 spine edit - #14832
Merged
Merged
Conversation
…ine edit. #14818 added a spine require without updating the committed sidecar stamp, breaking check-selfhost-spine-sidecar-sync and bootstrap-loop-probe M2 when the gen-0 fallback path runs main() but VM driver execute probe succeeds. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14831
Summary
prelinked/bootstrap-gen0/.m3_compiler_lib_sidecar.shato matchtest/selfhost/compiler_lib_spine_smoke/main.phpSHA-1 after php-in-php: quarantine StringJsonEncode M4 inventory stubs (#14817) #14818 addedStringJsonEncodeInventoryStubs.phpto the spine entry.PHP_COMPILER_VM_DRIVER_EXECUTE=1probe succeeds (Refresh compiler_lib spine sidecar after native full-spine AOT compile (#2201) #8559), refresh the sidecar stamp sobootstrap-loop-probeM2 no longer exits on stale stamp.Verification
Made with Cursor