Repository navigation
Fix var_export(array pointer) string-concat mis-bind (#13829) - #13894
Merged
Merged
Conversation
php-cfg hoists key()/current()/… as siblings before var_export with distinct dead arg temps; wire hoisted FuncCall return slots and skip ConstFetch true mis-binding on var_export arg #0. Also fixes #13811 prev/next/end concat regressions. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
var_export(key($a), true)(and siblings) inside string concatenation: php-cfg hoists array-pointer builtins as siblings with distinct dead arg temps; the VM was sendingtrue(ConstFetch) as var_export arg #0 instead of the hoisted FuncCall return.lib/Compiler.php: relaxslotForVarExportNestedInlineCallArgfeed check, run it before ConstFetch arg wiring, skip ConstFetch mis-bind on var_export arg #0, and teachcfgCallImmediatelyFeedsAdjacentConsumerabout ConstFetch gaps before var_export.prev()), Regression: current() string-concat nested operand — returns true not element (ext/standard/array.c) #13828 (current()), Regression: next() string-concat nested operand — returns true not element (ext/standard/array.c) #13830 (next()), Regression: end() second call in string-concat — returns true not last element (ext/standard/array.c) #13831 (end()) — same root cause.php-src reference
ext/standard/array.cpointer builtins; fix is compile-time arg wiring (lib/Compiler.php, Zend/zend_compile.c SEND/inline-call pattern).Verification
Closes #13829
Made with Cursor