Repository navigation
Stdlib: preg_match() float $offset coercion like Zend (#13818) - #13892
Merged
Merged
Conversation
…). Use VmMath::parseIntBuiltinArgForFrame for VM offset args and JitLongArg fpToSi for native double; compliance captures E_DEPRECATED via error handler. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preg_match()/preg_match_all()now coerce float$offsetviaVmMath::parseIntBuiltinArgForFrame(php-srcZ_PARAM_LONG/ext/pcre/php_pcre.c).JitLongArgtruncatesTYPE_NATIVE_DOUBLEwithfpToSifor JIT/AOT offset lowering.Closes #13818
Verification
Output:
PHPUnit (Docker):
OK (2 tests, 2 assertions)— VM + Zend PHPT reference.Made with Cursor