Repository navigation
Stdlib: settype() uninitialized typed property by-ref — Error not LogicException (#13884) - #13889
Merged
Merged
Conversation
…3884). Add TypedPropertyCheck::assertWritableByReference and invoke it from VmSettype before coercion so Zend's by-reference Error replaces the builtin LogicException. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypedPropertyCheck::assertWritableByReference()for Zend's by-reference guard on uninitialized non-nullable typed properties (ext/standard/type.c,Zend/zend_types.c).VmSettype::apply()invokes the guard before coercion sosettype($o->x, 'int')throws the ZendErrortext instead of a builtinLogicException.Closes #13884
Verification
Output:
PHPUnit (Docker):
OK (3 tests, 3 assertions)— VM + JIT compliance.Made with Cursor