Repository navigation
Regression: var_export() mangled array keys with NUL bytes (#13875) - #13878
Merged
Merged
Conversation
…13875). Match ext/standard/var.c php_array_element_export: addcslashes then emit '' . "\0" . ' segments for mangled property keys from get_mangled_object_vars(). Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
var_export()on arrays with NUL-byte keys (e.g. fromget_mangled_object_vars()) now emits php-src concatenation form:'' . "\0" . '*' . "\0" . 'w' => 1.ext/standard/VmVarExport.php— shared by VM and JIT viaVarExportJitHelper(php-in-php: JIT StringVarExportJit — route var_export() through VmVar PHP not __compiler_var_export LLVM (#1492) #9189).ext/standard/var.c—php_array_element_export()/php_str_to_strNUL replacement.Closes #13875
Test plan
Made with Cursor