Repository navigation
php-in-php: route preg_replace_callback through PregJitHelper PHP (#13736) - #13743
Merged
Merged
Conversation
…3736) Delete StringPregMatchStandaloneLlvm (~1272 LOC libpcre2 LLVM monolith); match loop lives in VmPregNative::pregReplaceCallbackJit with a thin LLVM callback invoke trampoline in PregMatchRuntime. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StringPregMatchStandaloneLlvm.php(1272 LOC libpcre2 LLVM monolith) — allpreg_*includingpreg_replace_callbacknow route throughPregMatchRuntime+ PHP helpers.PregJitHelper::replaceCallbackArgv()delegating toVmPregNative::pregReplaceCallbackJit()(pure-PHP match loop viaVmPregPure).PregCallbackInvokeJitHelper::invoke(function-pointer ABI preserved forJitPregReplaceCallbackshims).php-src ref:
ext/pcre/php_pcre.c—php_pcre_replace_implcallback formLOC removed:
lib/JIT/Builtin/StringPregMatchStandaloneLlvm.phpdeleted (−1272); net −1021 lines in PR.Closes #13736
Test plan
Made with Cursor